From d1761c730c2cbccadeb482642621837d3f33a16d Mon Sep 17 00:00:00 2001
From: Igor <bniwredyc@gmail.com>
Date: Thu, 11 May 2023 11:52:56 +0000
Subject: [PATCH] markup fixes

---
 src/components/Feed/ArticleCard.module.scss   |  1 +
 .../Feed/Sidebar/Sidebar.module.scss          | 32 ++++++++-
 src/components/Feed/Sidebar/Sidebar.tsx       | 69 +++++++++++--------
 src/components/Views/Edit.tsx                 | 20 +++---
 src/components/Views/Feed.module.scss         |  3 +-
 src/styles/app.scss                           | 11 +++
 6 files changed, 95 insertions(+), 41 deletions(-)

diff --git a/src/components/Feed/ArticleCard.module.scss b/src/components/Feed/ArticleCard.module.scss
index 91c0020f..9526c7fc 100644
--- a/src/components/Feed/ArticleCard.module.scss
+++ b/src/components/Feed/ArticleCard.module.scss
@@ -28,6 +28,7 @@
 
   .feedControlIcon {
     max-width: 2em;
+    vertical-align: text-bottom;
   }
 }
 
diff --git a/src/components/Feed/Sidebar/Sidebar.module.scss b/src/components/Feed/Sidebar/Sidebar.module.scss
index fd654010..fd66ff3e 100644
--- a/src/components/Feed/Sidebar/Sidebar.module.scss
+++ b/src/components/Feed/Sidebar/Sidebar.module.scss
@@ -53,7 +53,7 @@
   .settings {
     display: flex;
     justify-content: space-between;
-    margin-bottom: 2em;
+    margin: 2em 0;
   }
 
   a {
@@ -87,4 +87,34 @@
       width: 100%;
     }
   }
+
+  h4 {
+    color: #9fa1a7;
+    cursor: pointer;
+    @include font-size(1.2rem);
+    letter-spacing: 0.05em;
+    text-transform: uppercase;
+    position: relative;
+
+    &:after {
+      content: '+';
+      font-size: 1.6em;
+      line-height: 1;
+      position: absolute;
+      right: 2.5rem;
+      top: -0.2em;
+      transition: transform 0.3s;
+    }
+
+    &.opened {
+      &:after {
+        right: 0.9rem;
+        transform: rotate(45deg);
+      }
+    }
+  }
+
+  .hidden {
+    display: none;
+  }
 }
diff --git a/src/components/Feed/Sidebar/Sidebar.tsx b/src/components/Feed/Sidebar/Sidebar.tsx
index bf76695e..354f218b 100644
--- a/src/components/Feed/Sidebar/Sidebar.tsx
+++ b/src/components/Feed/Sidebar/Sidebar.tsx
@@ -1,4 +1,4 @@
-import { For } from 'solid-js'
+import { createSignal, For } from 'solid-js'
 import type { Author } from '../../../graphql/types.gen'
 import { useAuthorsStore } from '../../../stores/zine/authors'
 import { Icon } from '../../_shared/Icon'
@@ -28,6 +28,7 @@ export const Sidebar = (props: FeedSidebarProps) => {
   const { authorEntities } = useAuthorsStore({ authors: props.authors })
   const { articlesByTopic } = useArticlesStore()
   const { topicEntities } = useTopicsStore()
+  const [isSubscriptionsVisible, setSubscriptionsVisible] = createSignal(false)
 
   const checkTopicIsSeen = (topicSlug: string) => {
     return articlesByTopic()[topicSlug]?.every((article) => Boolean(seen()[article.slug]))
@@ -68,11 +69,6 @@ export const Sidebar = (props: FeedSidebarProps) => {
     {
       icon: 'feed-notifications',
       title: t('notifications')
-    },
-    {
-      href: '/feed?by=subscribed',
-      title: t('My subscriptions'),
-      isBold: true
     }
   ]
 
@@ -92,29 +88,46 @@ export const Sidebar = (props: FeedSidebarProps) => {
             </li>
           )}
         </For>
-        <For each={session()?.news?.authors}>
-          {(authorSlug: string) => (
-            <li>
-              <a
-                href={`/author/${authorSlug}`}
-                classList={{ [styles.unread]: checkAuthorIsSeen(authorSlug) }}
-              >
-                <small>@{authorSlug}</small>
-                {authorEntities()[authorSlug]?.name}
-              </a>
-            </li>
-          )}
-        </For>
-        <For each={session()?.news?.topics}>
-          {(topicSlug: string) => (
-            <li>
-              <a href={`/author/${topicSlug}`} classList={{ [styles.unread]: checkTopicIsSeen(topicSlug) }}>
-                {topicEntities()[topicSlug]?.title ?? topicSlug}
-              </a>
-            </li>
-          )}
-        </For>
       </ul>
+
+      <Show when={session()?.news?.authors || session()?.news?.topics}>
+        <h4
+          classList={{ [styles.opened]: isSubscriptionsVisible() }}
+          onClick={() => {
+            setSubscriptionsVisible(!isSubscriptionsVisible())
+          }}
+        >
+          {t('My subscriptions')}
+        </h4>
+        <ul classList={{ [styles.hidden]: !isSubscriptionsVisible() }}>
+          <For each={session()?.news?.authors}>
+            {(authorSlug: string) => (
+              <li>
+                <a
+                  href={`/author/${authorSlug}`}
+                  classList={{ [styles.unread]: checkAuthorIsSeen(authorSlug) }}
+                >
+                  <small>@{authorSlug}</small>
+                  {authorEntities()[authorSlug]?.name}
+                </a>
+              </li>
+            )}
+          </For>
+          <For each={session()?.news?.topics}>
+            {(topicSlug: string) => (
+              <li>
+                <a
+                  href={`/topic/${topicSlug}`}
+                  classList={{ [styles.unread]: checkTopicIsSeen(topicSlug) }}
+                >
+                  {topicEntities()[topicSlug]?.title ?? topicSlug}
+                </a>
+              </li>
+            )}
+          </For>
+        </ul>
+      </Show>
+
       <div class={styles.settings}>
         <a href="/feed/settings">
           <Icon name="settings" class={styles.icon} />
diff --git a/src/components/Views/Edit.tsx b/src/components/Views/Edit.tsx
index 725e647e..fc566823 100644
--- a/src/components/Views/Edit.tsx
+++ b/src/components/Views/Edit.tsx
@@ -117,20 +117,20 @@ export const EditView = (props: EditViewProps) => {
 
   return (
     <>
-      <button
-        class={clsx(styles.scrollTopButton, {
-          [styles.visible]: isScrolled()
-        })}
-        onClick={scrollTop}
-      >
-        <Icon name="up-button" class={styles.icon} />
-        <span class={styles.scrollTopButtonLabel}>{t('Scroll up')}</span>
-      </button>
-
       <div class={styles.container}>
         <Title>{t('Write an article')}</Title>
         <form>
           <div class="wide-container">
+            <button
+              class={clsx(styles.scrollTopButton, {
+                [styles.visible]: isScrolled()
+              })}
+              onClick={scrollTop}
+            >
+              <Icon name="up-button" class={styles.icon} />
+              <span class={styles.scrollTopButtonLabel}>{t('Scroll up')}</span>
+            </button>
+
             <div class="row">
               <div class="col-md-19 col-lg-18 col-xl-16 offset-md-5">
                 <div
diff --git a/src/components/Views/Feed.module.scss b/src/components/Views/Feed.module.scss
index 82a8af6d..6ea76b45 100644
--- a/src/components/Views/Feed.module.scss
+++ b/src/components/Views/Feed.module.scss
@@ -4,8 +4,7 @@
   font-weight: 500;
 
   h4 {
-    font-size: inherit;
-    margin-bottom: 1.6rem;
+    margin-bottom: 0.8em;
   }
 
   ul,
diff --git a/src/styles/app.scss b/src/styles/app.scss
index 1f1f76cc..55436ae6 100644
--- a/src/styles/app.scss
+++ b/src/styles/app.scss
@@ -262,12 +262,23 @@ button {
     background: #000;
     color: #fff;
     opacity: 1;
+
+    .icon {
+      filter: invert(1);
+    }
   }
 
   &[disabled]:hover {
     background: #fff;
     color: #000;
   }
+
+  .icon {
+    display: inline-block;
+    margin-right: 0.3em;
+    vertical-align: text-bottom;
+    width: 1.4em;
+  }
 }
 
 .button--content-index {