Compare commits

...

5 Commits

Author SHA1 Message Date
Lakhan Samani
7c2693b086 fix: form post template 2022-10-18 23:03:55 +05:30
Lakhan Samani
eaa10ec5bc fix: error detection 2022-10-18 22:34:57 +05:30
Lakhan Samani
253128ca0c fix: query params for code response 2022-10-18 22:00:54 +05:30
Lakhan Samani
cddfe1e088 fix: response 2022-10-18 21:46:37 +05:30
Lakhan Samani
8e655bcb5b fix: authorize response 2022-10-18 21:29:09 +05:30
2 changed files with 39 additions and 36 deletions

View File

@@ -86,7 +86,7 @@ func AuthorizeHandler() gin.HandlerFunc {
loginError := map[string]interface{}{
"type": "authorization_response",
"response": map[string]string{
"response": map[string]interface{}{
"error": "login_required",
"error_description": "Login is required",
},
@@ -106,13 +106,14 @@ func AuthorizeHandler() gin.HandlerFunc {
handleResponse(gc, responseMode, loginURL, redirectURI, loginError, http.StatusOK)
return
}
userID := claims.Subject
user, err := db.Provider.GetUserByID(gc, userID)
if err != nil {
log.Debug("GetUserByID failed: ", err)
handleResponse(gc, responseMode, loginURL, redirectURI, map[string]interface{}{
"type": "authorization_response",
"response": map[string]string{
"response": map[string]interface{}{
"error": "signup_required",
"error_description": "Sign up required",
},
@@ -152,37 +153,39 @@ func AuthorizeHandler() gin.HandlerFunc {
// in case, response type is code and user is already logged in send the code and state
// and cookie session will already be rolled over and set
gc.HTML(http.StatusOK, authorizeWebMessageTemplate, gin.H{
"target_origin": redirectURI,
"authorization_response": map[string]interface{}{
// gc.HTML(http.StatusOK, authorizeWebMessageTemplate, gin.H{
// "target_origin": redirectURI,
// "authorization_response": map[string]interface{}{
// "type": "authorization_response",
// "response": map[string]string{
// "code": code,
// "state": state,
// },
// },
// })
params := "code=" + code + "&state=" + state
if responseMode == constants.ResponseModeQuery {
if strings.Contains(redirectURI, "?") {
redirectURI = redirectURI + "&" + params
} else {
redirectURI = redirectURI + "?" + params
}
} else if responseMode == constants.ResponseModeFragment {
if strings.Contains(redirectURI, "#") {
redirectURI = redirectURI + "&" + params
} else {
redirectURI = redirectURI + "#" + params
}
}
handleResponse(gc, responseMode, loginURL, redirectURI, map[string]interface{}{
"type": "authorization_response",
"response": map[string]string{
"response": map[string]interface{}{
"code": code,
"state": state,
},
},
})
// params := "code=" + code + "&state=" + state
// if responseMode == constants.ResponseModeQuery {
// if strings.Contains(redirectURI, "?") {
// redirectURI = redirectURI + "&" + params
// } else {
// redirectURI = redirectURI + "?" + params
// }
// } else if responseMode == constants.ResponseModeFragment {
// if strings.Contains(redirectURI, "#") {
// redirectURI = redirectURI + "&" + params
// } else {
// redirectURI = redirectURI + "#" + params
// }
// }
// handleResponse(gc, responseMode, loginURL, redirectURI, map[string]interface{}{
// "code": code,
// "state": state,
// }, http.StatusOK)
}, http.StatusOK)
return
}
@@ -284,7 +287,7 @@ func validateAuthorizeRequest(responseType, responseMode, clientID, state, codeC
func handleResponse(gc *gin.Context, responseMode, loginURI, redirectURI string, data map[string]interface{}, httpStatusCode int) {
isAuthenticationRequired := false
if _, ok := data["error"]; ok {
if _, ok := data["response"].(map[string]interface{})["error"]; ok {
isAuthenticationRequired = true
}
@@ -305,7 +308,7 @@ func handleResponse(gc *gin.Context, responseMode, loginURI, redirectURI string,
case constants.ResponseModeFormPost:
gc.HTML(httpStatusCode, authorizeFormPostTemplate, gin.H{
"target_origin": redirectURI,
"authorization_response": data,
"authorization_response": data["response"],
})
return
}

View File

@@ -4,9 +4,9 @@
<title>Authorization Response</title>
</head>
<body onload="document.forms['authorize_form_post'].submit()">
<form action={{.target_origin}} name="authorize_form_post">
<form action="{{.target_origin}}" name="authorize_form_post" method="POST">
{{ range $key, $val := .authorization_response }}
<input type="hidden" key={{$key}} value={{$val}} name={{$key}} id={{$key}} />
<input type="hidden" key="{{$key}}" value="{{$val}}" name="{{$key}}" id="{{$key}}" />
{{ end }}
</form>
</body>