devstack/authorizer
4
0
Fork 0
Code Pull Requests Actions Activity

fix: oauth state split

Browse Source
This commit is contained in:
Lakhan Samani 2022-03-08 19:13:45 +05:30
parent 917eaeb2ed
commit fd9eb7c733
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/handlers/oauth_callback.go
View File

@ -37,7 +37,7 @@ func OAuthCallbackHandler() gin.HandlerFunc {
} }
sessionstore.GetState(state) sessionstore.GetState(state)
// contains random token, redirect url, role // contains random token, redirect url, role
sessionSplit := strings.Split(state, "@") sessionSplit := strings.Split(state, "___")
if len(sessionSplit) < 3 { if len(sessionSplit) < 3 {
c.JSON(400, gin.H{"error": "invalid redirect url"}) c.JSON(400, gin.H{"error": "invalid redirect url"})

2
server/handlers/oauth_login.go
View File

@ -58,7 +58,7 @@ func OAuthLoginHandler() gin.HandlerFunc {
roles = strings.Join(envstore.EnvStoreObj.GetSliceStoreEnvVariable(constants.EnvKeyDefaultRoles), ",") roles = strings.Join(envstore.EnvStoreObj.GetSliceStoreEnvVariable(constants.EnvKeyDefaultRoles), ",")
} }
oauthStateString := state + "@" + redirectURI + "@" + roles + "@" + strings.Join(scope, ",") oauthStateString := state + "___" + redirectURI + "___" + roles + "___" + strings.Join(scope, ",")
provider := c.Param("oauth_provider") provider := c.Param("oauth_provider")
isProviderConfigured := true isProviderConfigured := true